report_clear() efficiency, plus clear after grep #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2b384f6 introduced a performance regression due to use of wclear(), which dirties the entire screen. The core issue being addressed in 2b384f6 is that readline can leave an incorrect cursor position in virtual window newscr. So, explicitly reset the newscr cursor position post-readline, which enables switching to the much more efficient werase() for erasing the status area. Incidentally fix the missed case of report_clear() after a grep prompt.
|
To clarify something I should have explained in the original comment here, |
|
Thanks for clarifying. I like the use of werase instead of wclear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2b384f6 introduced a performance regression due to use of
wclear(), which dirties the entire screen. This can be seen in the form of flickering: enter the main view and hold down <Up>.The core issue being addressed in 2b384f6 is that readline can leave an incorrect cursor position in virtual window
newscr(which can be inspected usinggetyx()).So, explicitly reset the
newscrcursor position post-readline, which enables switching to the much more efficientwerase()for erasing the status area.Incidentally fix the missed case of
report_clear()after a grep prompt.